This is the first pre-release of Thunder for v0.2.1+11! (if all things go accordingly and I don’t mess up TestFlight builds again)
Just an update: I’ll have a bit less time this week to work on Thunder, so updates may take a bit longer than before.
Be fully prepared to know that these pre-release versions may contain major bugs which could cause Thunder to crash or behave unexpectedly.
Without further ado, these are the changes from last time (based off changelog):
Added
- Added colour to username in comments to distinguish your own comments
- Added option to allow text preview on text posts in normal view - contribution from @coslu
- Added option to share media link or external URL links in the dialog popup on post long press
- Added back featured post icon on posts within a community
- Added ability to customize swipe gestures on comments and posts
- Added ability to develop with hot reload using docker - contribution from @Fmstrat
- Added initial implementation for font size scaling for titles and content - this is very very rough at the moment so feedback is appreciated
Changed
- Adjusted visual feedback in comment swipe gestures
- Added option in settings to enable/disable swipe on bottom navigation bar to open sidebar on feed page - contribution from @bactaholic
- Added option in settings to enable/disable double-tap on bottom navigation bar to open sidebar on feed page (this is disabled temporarily) - contribution from @bactaholic
- Decreased scroll distance needed in order to fetch more comments from a thread
- Improved error messages when more comments fail to fetch within a post
- Decreased number of comments to fetch at a time to improve loading performance
- Posts now load first before comment threads to make viewing posts more responsive
Fixed
- Potentially fixed issues with HTTPS certificate errors when running on Android using Adguard with HTTPS filtering enabled
- Improved performance for comment threads with a lot of comments
- Fixed issue where the last comment on a thread could potentially not show up
- Fixed issue where markdown links were not respecting “open in external browser” option - contribution from @Fmstrat
- Fixed issue with download media not working on Android for some users - contribution from @minicit
- Fixed issue where media download button appearance in light mode - contribution from @coslu
For things to test out, I would suggest:
- general testing of app overall, vote, reply, comment, share, etc.
- testing of custom swipe actions
- scrolling through long comment threads
- changing all of the settings in the setting pages
Anyone else not seeing all comments load? I know there have been more comments on this post than thunder is showing. It was showing part of a comment chain from myself and now its just not.
Edit: as an example this is the web ui while this is thunder showing the same thread
I have noted down this issue - it should be fixed in the next nightly release!
Edit: To be a bit more transparent, this is what was happening:
Comment fetching is paginated, which means that it only fetches x amount of comments at a time. What was happening is the following:
- When there is a long comment thread, there are cases where the comments that are being fetched don’t fetch all of the comment’s replies (e.g., if a comment has 30 replies, but only 10 of them get fetched, then this is where the issue pops up)
- Then, on the next comment fetch, if some comments were part of a previous comment’s reply, there was a bug where it would not attach that comment to the parent comment
- Because the comment replies were not being attached, they just ended up being lost and caused the comments to not show up
🐛🐛🐛
Heads up to testers : I had to do a clean install because my app was in a weird connected but not connected mood. Wouldn’t show up my feeds, content or account but when I clicked on manage accounts it would still show me as connected, without being able to disconnect said account.
Just curious but are you on the lemmy.world instance? I know I’ve been having a lot of connection issues with lemmy.world which causes some things to happen
- the account profile page doesn’t show your account (this is because it couldn’t fetch your account details properly)
- The subscriptions in the sidebar doesn’t show up properly (this is also because it couldn’t fetch your account details)
If you try out another instance with less connection issues, those symptoms seem to disappear completely
I am, changed the instance to lemmy.world after the posting issue from lemmy.ml. Both of your points happened, but seems a bit too convenient as I tried to reload the app 3 times with no success but everything went well after the clean install (and everything was fine minutes before update as well). Not sure what’s happening but just want to warn testers in case it happens to them, didn’t intend to bother you (yet) with that one !
Yeah, I’ve noticed a bit of issues with both lemmy.world and lemmy.ml - both of them (but moreso lemmy.world) have been causing some issues because of connection reasons for me
I can confirm that this works. I haven’t encountered any connection issues after switching to another instance.
Updated and looking good so far
OH NO! the post paragraphs, links, etc used to read as seperate elements but starting with this pre-release its stopped doing that. Please revert that change as it is much better as seperate elements.
Edit: also, is hitting the post icon on comments closing the thread for anyone else?
OH NO! the post paragraphs, links, etc used to read as seperate elements but starting with this pre-release its stopped doing that.
Hmm, I don’t think there was any change in the logic for that, but I’ll double check it. Can you give me an example with screenshots if possible?
is hitting the post icon on comments closing the thread for anyone else?
By this, do you mean when you create a new comment? (e.g., creating a new comment within a post causes it to go back to the previous page?)
Sure. Here is a screenshot from the pre release. Note how the entire OP is inside the green box whereas in this screenshot and this screenshot only the paragraphs are highlighted.
Note, these only last for 72 hours before being deleted.
To your second question when you are in a thread and reply to an OP (and maybe a comment too as i havent tested it) the thread is totally closed when the reply button is pressed and the reply is sent. You end up back on the feed
Sure. Here is a screenshot from the pre release. Note how the entire OP is inside the green box whereas in this screenshot and this screenshot only the paragraphs are highlighted.
Alright, I think I understand the issue - still not too sure what caused that to happen, but I’ll see if I can figure that out
To your second question when you are in a thread and reply to an OP (and maybe a comment too as i havent tested it) the thread is totally closed when the reply button is pressed and the reply is sent. You end up back on the feed
I think I may have just fixed this one just now - doing a bit more testing on it first
Could you get things in comments to read as seperate elements too?
I’ve figured out the issue with the post reading as one big element, haven’t been able to do the same for comments yet
Thats good. Thanks
Welp, it seems like fixing the talkback issue caused a different issue to occur where I can’t scroll up in the comment threads anymore.
I’ll have to take a deeper look at this 😅
Great update!
I’m sure it has a lot to do with switching instances, but this update is smooooth. Everything working smappily and as expected so far :) will try to edit this comment when I’m done and see if that’s fixed itself on my end…
When text scaling was added in, was the base size made smaller? It’s not that different but it feels a bit closer to the Small setting than the Large setting. I’d personally bump that one back up to where it was, but if it’s tied to my system font maybe that won’t be possible?
Either way, keep up the great work!
I don’t understand what’s wrong with me, but I still can’t bring up the ability to edit comments 😭 when I swipe on my own comments I get the same options as I do for other comments (voting/reply/save). It’s supposed to replace reply, right? I’ve done fresh installs and purged my data through the last two releases and still can’t figure this out. Halp!
Apparently this issue is also occurring for another person, this is the link: https://github.com/hjiangsu/thunder/issues/175#issuecomment-1620140588
I’ll take a closer look at it and see if I can figure it out
I think we’re onto something - it most likely has something to do with your display name vs username. Could you try to login using your username rather than your display name if you have that set and see if it works? capitalization matters in this case
Regardless, I’ll be making it so that the logic will check for your user id rather than username so that it makes it more robust!
Edit: doing a test edit here to check for something
Edit Edit: More edits are cooler
I don’t have a display name set (to my knowledge) but I also didn’t write my username in capitals on sign in - I can test that now!
EDIT: SUCCESS! Good sleuthing, sir! Only strange behavior I’m seeing now is that the haptic feedback goes a little nuts when you slide to the edit icon, for some reason? I can file a ticket for that!
EDIT: SUCCESS! Good sleuthing, sir! Only strange behavior I’m seeing now is that the haptic feedback goes a little nuts when you slide to the edit icon, for some reason? I can file a ticket for that!
YAY thats good to hear! I have already noted the haptic feedback issue and have fixed that already hopefully (in for the next nightly release)
You’re a wizard and a legend 🫡 continuously impressed by your work!
Just doing my best :D
Also when I send a comment in this post it does that successfully, but it kicks me out of post view and back into the community feed. I don’t think that was happening before?
This was probably introduced in the pre-release, heres the issue link:https://github.com/hjiangsu/thunder/issues/218
woah you are right, I think a long-press is in order.
BTW, devs, anywhere I can submit suggestions? Two soecifically that come to mind…
Having links produce a pop-up, instead of immediately proceeding. The popup should show the full link path, and have a buttom to either proceed, open with, or copy the link.
2nd thing I’d like (not as important) the ability to select the text of a comment. As in being able to highlight a portion for me to copy to the clipboard.
And of course aside from any beginning alpha bugs this app is incredibly nice.
You should check out the GitHub page and file any bugs/requests there if they’re not yet covered (though I would also check out the latest nightly build, as it’s only getting better!)
Am I just an old geezer or is base font size way too small?
yeah, and large feels way too big
Hey! Yeah, I’m still working on tweaking the base values. There’s a weird issue that I’m working with on this. On Android, the scaling seems to work fine (1.0 scale is the base scale of what your phone’s font scale is set to)
However, on iOS, it seems to me like all the text gets larger even when a scale of 1.0 is set. I’m trying to get a value in between the two so that its not too small on Android, and also not too large on iOS
I wonder if it’s possible to have a different set of config values like that depending on the OS?
It did get smaller in this update, at least on Android - sounds like it’s still WIP though!
Oh I’m absolutely aware it’s a WIP. This is the nightly channel after all 😀. Just thought I’d ask if others also thought that the font sizes were too small.
