Nike shorts have consistently felt best so I’ve used them over the years. In terms of fit they need to be fitting (tights part) but not super tight. Like you should feel they are there is they fit right. Try not to the the “entry” level ones though. wait for a sale and get the next level up. The quality is generally much better and they will last longer.
But yeah you shouldn’t notice them when they are on and make sure you can “squat” down comfortably wearing them.
They already have magsafe chargers. TBH that would be the best move for Apple. The downside would be no more direct cable data backups. That makes me think no choice but USBC for this next phone.